-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag and Drop Files into Folder #1417
Comments
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already. |
Thanks for the feature suggestion! Related to #704. This would be super, super useful. Another related suggestion is allowing file renaming with slashes (#765). All slightly different features though! I think this is a great idea. I also wonder how this would work, from a UI/UX perspective, to also support #375. |
@catarak I would like to look give it a try. Can you please tell me the files, that I need to look at to get started? |
@SundeepChand sure! I would take a look at |
@SundeepChand if u aren't working on it I would like to give it a try. |
Sure @ron-debajyoti, you can work on this. |
@catarak Hi ! Sorry for being late, I was having some difficulties going through the code. A feature suggestion from me would be a proper documentation for developers (esp for newbies like me), and perhaps using Docusaurus. Regarding the drag and drop utility in the @catarak I would appreciate your views and suggestions regarding this problem. |
@catarak I did a temporary fix to the issue for now. I added a dropzone to the bottom of Although this fix technically doesn't allow us to rearrange the files within the I'll try to add a PR and try to solve related issues like #765 in this PR itself. Demo video: demo1.mp4 |
The way I understand this is that the currently the For the drag and drop, React DnD seems like the way to go. I would like to work on this issue so please assign it to me if it is still active. @lindapaiste @raclim |
Yes that sounds good. There is the UI portion, which is handling the drag action and using it to initiate moving the file. Then there's the Redux portion where we need to move the file to have a different parent. We actually don't have support for that right now. I can help you with the Redux part because the files reducer is a mess. You should focus on the UI, and triggering the right action at the right time. |
Alright, I will start creating the UI using React DnD.
After I'm done with the UI, I'll look into the files reducer and see if I can work on it. If I can't, I will submit the UI section in a PR and leave Redux to you. |
Nature of issue?
New feature details:
So I noticed how when you create a folder in p5.js, you can't drag and drop existing files into that folder. Instead you have to manually import files into that specific folder. So I'm wondering, could it be a possibility that you could drag and drop existing files into a folder? Thanks
The text was updated successfully, but these errors were encountered: