Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton with variant="invisible" has non-invisible disabled styling #5421

Open
iansan5653 opened this issue Dec 12, 2024 · 2 comments
Open

Comments

@iansan5653
Copy link
Contributor

iansan5653 commented Dec 12, 2024

IconButton's invisible variant renders the button as a simple icon with no border. However, if you then apply disabled to that button, a border appears. The result is distracting changes (border and background) as buttons switch from disabled to enabled and back:

Demo with enabled & disabled invisible iconbuttons. The disabled button has a border and background.

The effect of this can be seen in practice in the comment editor toolbar when submitting issue comments:

Screen.Recording.2024-12-12.at.10.54.32.AM.mov

I would expect disabled versions of invisible buttons to just be the same styling but with a slight fade-out (ie, translucency).

@siddharthkp
Copy link
Member

siddharthkp commented Dec 12, 2024

Hi! I talked to @langermank about this and she's happy to accept a PR. I might try to create on tomorrow unless you want to race me on it 😄

(note: need to update both js and module.css styles)

cc @francinelucca

@iansan5653
Copy link
Contributor Author

iansan5653 commented Dec 12, 2024

unless you want to race me on it

🐎 #5423

note: need to update both js and module.css styles

As far as I can tell from the code, the JS styles have already been removed and CSS modules is globally shipped for buttons. I could be wrong though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants