Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty-quick --check is fixing files #106

Open
elvirdolic opened this issue Jun 4, 2020 · 2 comments
Open

pretty-quick --check is fixing files #106

elvirdolic opened this issue Jun 4, 2020 · 2 comments

Comments

@elvirdolic
Copy link

Hi,

I wanted to use pretty-quick --check during CI to prevent that not formatted code is landing in master. But the --check property seems not to work correctly

pretty-quick version: 2.0.1

yarn pretty-quick 
yarn run v1.22.4
$ \node_modules\.bin\pretty-quick
�🔍  Finding changed files since git revision 159bf55e4.
�🎯  Found 1 changed file.
✍️  Fixing up add-user.actions.ts.
✅  Everything is awesome!
Done in 3.02s.
PS yarn pretty-quick --check  
yarn run v1.22.4
$ node_modules\.bin\pretty-quick --check
�🎯  Finding changed files since git revision 159bf55e4.
�🔍  Found 1 changed file.
✍️  Fixing up add-user.actions.ts.
✅  Everything is awesome!
Done in 2.47s.

--check and without check are doing the fixing but I just want to fail the job with --check flag

@azz
Copy link
Member

azz commented Aug 21, 2020

Hey @elvirdolic. Are you still experiencing this? This isn't the expected behaviour at all. If you are able to gather some extra diagnostic info that would go a long way to solving your issue.

@JounQin
Copy link
Member

JounQin commented Jan 16, 2024

A minimal but runnable online reproduction is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants