Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CodeMirror #1161

Open
Meisolsson opened this issue Feb 23, 2018 · 2 comments
Open

Replace CodeMirror #1161

Meisolsson opened this issue Feb 23, 2018 · 2 comments

Comments

@Meisolsson
Copy link
Contributor

In my opinon CodeMirror is not the best wat for us to display code. To replace it I'd prefer to use something like https://github.com/kbiakov/CodeView-android and https://github.com/noties/Markwon.

If you have other ideas on how to do this or if you think this is a bad idea feel free to comment.

@Meisolsson Meisolsson mentioned this issue Feb 23, 2018
3 tasks
@veyndan
Copy link
Collaborator

veyndan commented Mar 20, 2018

You stated that you wanted to display code, but stated the use of Markwon which only renders Markdown. Therefore I've assumed that you mean to replace the Markdown renderer.

CodeMirror definitely needs to be replaced. I've found it slow to render markdown and also having horizontal scrolling of a markdown document is less than ideal.

Another option which is extremely popular is Bypass. As another bonus, it's used in the extremely popular app plaid produced by a Google employee. Personally I'd go with Bypass purely based on it being more popular compared to the two you linked.

@Meisolsson
Copy link
Contributor Author

Well it's for both to be honest. Using codeview to render actual code is slow so using Code-View for that was an option. Then looking at Markdown we want to render it so either Markwon or Bypass.

I will take a look at both Bypass and Markwon but I'm remembering that we need to support GFM (GitHub Flavored Markdown). It's easier to do with just rendering Markdown via the GitHub API and handling it with Html.fromHtml(...) with some custom TagHandler probably.

For code I think CodeView is the best, but there might be better options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants