Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new release #47

Open
andrcuns opened this issue May 5, 2021 · 8 comments
Open

Publish new release #47

andrcuns opened this issue May 5, 2021 · 8 comments

Comments

@andrcuns
Copy link

andrcuns commented May 5, 2021

Hi,

I have been using spinner in one of my projects and it works great, however I could really use some of the latest master branch additions, mainly:

  • log method to print above spinner
  • tty? method which seems to be private in the released version.

Have you considered pushing a new release any time soon?

@piotrmurach
Copy link
Owner

Hi Andrejs 👋

Thanks for using this gem in your project.

My plan was to look at the timer and multi-spinner issues. However, there is no reason why I cannot make this release earlier. I will see what I can do.

@piotrmurach
Copy link
Owner

@andrcuns This is still on my list and I plan to make a release this coming weekend.

@jgarth
Copy link

jgarth commented Jan 17, 2022

Hi @piotrmurach! Thanks for making this (and the other cool parts of tty). I'd also benefit from a new release, instead of relying on master in my Gemfiles. Can I help with the release somehow?

@piotrmurach
Copy link
Owner

@jgarth Yes, you can. The log method isn't fully robust for release. Here's the Spinner breaks on multiline message issue that needs resolving. My last comment summarises the problem and possible solutions. Once this is addressed, I think we will be in a good place to cut a new release.

@fwolfst
Copy link

fwolfst commented Oct 26, 2022

Also if you'd release we could use the 🚨 lighthouse-spinner ee6651a ;)
And thanks for all the tty!

@NielsKSchjoedt
Copy link

+1

@MadBomber
Copy link

If the methods are not available, the README documentation should at least reflect that they are either not available but planned or they should be. removed from the README completely.

I added this patch to my code for a log method:

module TTY
  class Spinner
    # Log a message to the output
    # This will clear the current spinner line, print the log message,
    # and then redraw or resume the spinner on a new line.
    #
    # @param [String] message
    #   the log message to print
    #
    # @api public
    def log(message)
      synchronize do
        clear_line    # Clear the spinner
        output.puts(message) # Log the message
        redraw_indent # Redraw the spinner frame
      end
    end
  end
end

@dmorgan-fa
Copy link

@piotrmurach, thanks for all of the work on the fleet of tty tools, they're fantastic!
Is there any chance of getting a release for this gem to support .log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants