Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel function is missing on promises. #21

Open
tolgaulas opened this issue Oct 20, 2021 · 1 comment
Open

cancel function is missing on promises. #21

tolgaulas opened this issue Oct 20, 2021 · 1 comment

Comments

@tolgaulas
Copy link

Description
the cancel function is missing, causing programs to hang even an exception is thrown. Despite Promises/A+ does not mention .cancel, many promise capable libraries (i.e GUZZLE, REACTPHP) provides such feature.

Example
$promise.cancel();

@dbu
Copy link
Contributor

dbu commented Jan 4, 2024

to make things optional, we could add a CancellablePromise interface and implement that in the guzzle adapter promise to expose the guzzle promise cancel method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants