Add GetClient method to all implementations #185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glimchb
force-pushed
the
getclient
branch
3 times, most recently
from
c6d5127 to
cdf3549
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 63.64% 62.40% -1.25%
==========================================
Files 25 25
Lines 2107 2149 +42
==========================================
Hits 1341 1341
- Misses 651 693 +42
Partials 115 115 ☔ View full report in Codecov by Sentry. |
this will allow users to amend few settings after c-tor Fixes philippgille#184 Signed-off-by: Boris Glimcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow users to amend few settings after c-tor
Fixes #184
Signed-off-by: Boris Glimcher [email protected]