Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to all store configs and use it in Context #183

Open
glimchb opened this issue Feb 6, 2024 · 0 comments
Open

Add timeout to all store configs and use it in Context #183

glimchb opened this issue Feb 6, 2024 · 0 comments

Comments

@glimchb
Copy link
Contributor

glimchb commented Feb 6, 2024 

          Something else came to mind: With some store configs having a timeout parameter, we should either document that they are completely ignored, _or_ in the `WithContext` methods we could check for an existing ctx timeout, and when one is set we leave it as is, but when none is set we derive a new ctx with the timeout from the store config.

Originally posted by @philippgille in #136 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glimchb