Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLS: 1.0.5 #34684

Closed
simonjayhawkins opened this issue Jun 10, 2020 · 31 comments
Closed

RLS: 1.0.5 #34684

simonjayhawkins opened this issue Jun 10, 2020 · 31 comments
Labels
Release
Milestone
1.0.5

Comments

@simonjayhawkins
Copy link
Member

xref #34664 (comment)

@simonjayhawkins do you have time one of those days to do a 1.0.5 release?

can do. do we want to include anything else, wait a few weeks before doing the release and see if anything else surfaces or just get a patch release done with the S3 changes?

I would personally just do a patch release with the S3 changes, and not wait a few weeks with that. But maybe open a RLS issue for it to get some feedback from others?

cc @pandas-dev/pandas-core
@simonjayhawkins simonjayhawkins added this to the 1.0.5 milestone Jun 10, 2020
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jun 10, 2020 •
edited
Loading

(note it's not only S3, but also from file-like objects -> #34626, #34467)

I would personally do a patch release (with the revert of the parquet changes) now, if possible, and not wait a few weeks more with that (it's already 2 weeks since 1.0.4 is out).

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jun 10, 2020 •
edited
Loading

@simonjayhawkins are you able to manage the release again?

Might want to include #34667.

@samukweku
Copy link
Contributor

Hi Team, great work. Pandas version on pip and condas show version 1.0.4, although details of Pandas 1.1.0 can be found on the website. Any date when Pandas 1.1.0 will be available for download?

@jorisvandenbossche
Copy link
Member

although details of Pandas 1.1.0 can be found on the website.

Then you are looking at the dev docs, the stable docs show 1.0.4: https://pandas.pydata.org/pandas-docs/stable/

For 1.1, we're targetting end of June for a release candidate

@simonjayhawkins
Copy link
Member Author

@simonjayhawkins are you able to manage the release again?

Might want to include #34667.

no problem. #34667 is tagged 1.0.5 so hopefully that'll auto backport.

@jorisvandenbossche
Copy link
Member

@simonjayhawkins when would you have time to do the release?

IMO there is no point in waiting any longer. The release is already out for more than 2 weeks, and no other reports came in, while it's breaking a lot of people's parquet usage.

@simonjayhawkins
Copy link
Member Author

IMO there is no point in waiting any longer.

should we at least backport tests for #34626, #34467 to be sure? do we have a test for #34626? #34500 has been merged so can break off the tests for #34467

@jorisvandenbossche
Copy link
Member

Adding those tests to 1.0.x sounds good, yes

@simonjayhawkins
Copy link
Member Author

OK. will get on and backport #34667 and the test from #34500 now so we can check ci on 1.0.x is green

also need to update the whatsnew, #34500 (comment)

@jorisvandenbossche
Copy link
Member

also need to update the whatsnew, #34500 (comment)

I already did that: #34785

@simonjayhawkins
Copy link
Member Author

I already did that: #34785

Thanks Joris

@simonjayhawkins
Copy link
Member Author

just #34800 outstanding ( some doctest errors)

we didn't have the github actions running on previous release so this is probably not a blocker but some added confidence that the docs are building. so probably won't continue with the PR.

calling it a day. will pick up tomorrow (set date in whatsnew and tag)

lmk if anything else crops up. (set milestone or label as needs manual backport)

@simonjayhawkins
Copy link
Member Author

have made progress on release scripts pandas-dev/pandas-release#32 today.

currently on doc build.

previous release was a mash-up of git bash, docker and Anaconda prompt.

with line endings, problems with sharing volumes in git bash, and having git in conda in git bash adding to the grief.

hopefully it'll be smoother this time, but using Windows on a low powered/low ram laptop with a slow metered mobile connection doesn't help.

@TomAugspurger
Copy link
Contributor

LMK if there's anything I can help with. I can handle the doc build if it's going too slowly.

@jorisvandenbossche
Copy link
Member

BTW, not for today of course, but longer term, shouldn't we be able to use the docs built on CI? Like we already upload it for the dev docs, couldn't we upload it if it is on an exact tag?
In such a case, if the /version/1.0.5/ would be uploaded, the only manual thing that is needed is update the stable symlinks.

@simonjayhawkins
Copy link
Member Author

LMK if there's anything I can help with. I can handle the doc build if it's going too slowly.

Thanks. doing the doc build to manually inspect, as Joris says and #34800 (comment), maybe a better way.

I think that if you can upload the docs like last time, then i've done enough on the scripts to start the release process first thing tomorrow

BTW, not for today of course, but longer term, shouldn't we be able to use the docs built on CI? Like we already upload it for the dev docs, couldn't we upload it if it is on an exact tag?
In such a case, if the /version/1.0.5/ would be uploaded, the only manual thing that is needed is update the stable symlinks.

yeah, we have #21050 for better automation. I'm in a better position to help with this now!

@simonjayhawkins
Copy link
Member Author

tagging locally now. will be pushing in a few hours.

@simonjayhawkins
Copy link
Member Author

@TomAugspurger The order of events is different in the README an the Makefile. Should the doc upload be done first this time before creating the release.

@simonjayhawkins
Copy link
Member Author

P.S. Tag has been pushed.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jun 17, 2020 via email

@simonjayhawkins
Copy link
Member Author

doc upload in progress

@jorisvandenbossche
Copy link
Member

From #34855 (comment)

( I now have access to the web server so can do this b4 the github release next time)

I do not have access to PyPI so IIUC we don't switch the docs to stable till the wheels are upload?

Yes, I think ideally we wait with changing the symlinks until it is on PyPI (but the /version/x.x.x/ docs of course can be uploaded already)

For PyPI, can I help with uploading wheels?
(or we could give you upload rights (but I can't change that), don't know if we want to generally limit the number of accounts with access to PyPI)

@simonjayhawkins
Copy link
Member Author

For PyPI, can I help with uploading wheels?

the wheels are in the staging area so are ready for upload

@TomAugspurger
Copy link
Contributor

I can upload the wheels now.

@simonjayhawkins
Copy link
Member Author

Thanks Tom

@TomAugspurger
Copy link
Contributor

The wheels are up. @simonjayhawkins do you want to adjust the symlinks for stable?

@simonjayhawkins
Copy link
Member Author

The wheels are up. @simonjayhawkins do you want to adjust the symlinks for stable?

i've run link-stable. does link-version still apply with the new website?

@simonjayhawkins
Copy link
Member Author

i've run link-stable. does link-version still apply with the new website?

ahh this is to link v1.0 to v1.0.5? so this is needed.

@simonjayhawkins
Copy link
Member Author

The wheels are up. @simonjayhawkins do you want to adjust the symlinks for stable?

done. I think ready for announce. I can do mailing list. Can you do Twitter?

@jorisvandenbossche
Copy link
Member

Stable docs look good.

Thanks a lot Simon and Tom!

@TomAugspurger
Copy link
Contributor

Thanks Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
4 participants
@jorisvandenbossche @TomAugspurger @simonjayhawkins @samukweku