Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Parser seems to produce unexpected results #22

Open
jaserud opened this issue Feb 26, 2020 · 0 comments
Open

BUG - Parser seems to produce unexpected results #22

jaserud opened this issue Feb 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@jaserud
Copy link
Contributor

jaserud commented Feb 26, 2020

There is an inconsistency between how rollcall's index parser sees shard name and how it is shown in the index name

Description

Consider the index name file_centric_cl_clinic-a_re_2
Rollcall breaks this down by parsing it like this:

entity = file
type = centric
shardPrefix = cl
shard = clinc (notice the '-a' has been dropped)
re = re
release = 2
indexName = file_centric_cl_clinic-a_re_2 (this still has the '-a')

There is a grammar file which describes what is expected for each part (i.e. regexs)
The grammer is currently expecting [a-zA-Z0-9]+

Expected Behaviour

-Either It should compain that the regex didn't match
-Or the index name should be file_centric_cl_clinic_re_2 (no '-a')

Actual Behaviour

-As describe above

Possible Fix

  • update grammer files
  • investigate parser and fix
  • add tests
@jaserud jaserud added the bug Something isn't working label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant