Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create new user with a Google account that has an empty family name field #727

Open
anncatton opened this issue Sep 11, 2023 · 0 comments
Assignees

Comments

@anncatton
Copy link
Contributor

To reproduce:

  • using a Google account that does NOT have an existing user in Ego, update your Google Personal Info -> Name info to leave the Last Name field blank:
    Private Zenhub Image

  • log into Ego with this Google account

Result: After successfully authenticating with Google oauth, the /ego-token endpoint will respond with a 400 error:
Private Zenhub Image

Cause:
The CreateUserRequest.builder call fails because it is expecting a value for the family_name field.

Solution:
Some of the other providers do not guarantee this field exists so their builder calls include a default empty string value on creation. Update the create user flow so that this is the default approach.

@anncatton anncatton self-assigned this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant