-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include function argument names as part of "function-arguments" for introspector API #1175
Comments
We extract this for C/C++ in the frontend fuzz-introspector/frontends/llvm/lib/Transforms/FuzzIntrospector/FuzzIntrospector.cpp Line 1072 in 13ba8d5
However, when expecting the output the values are all empty strings. It could be this is gone at the point we extract them. I need to investigate a bit more -- it may be we need to open up for a way to inspect these values at a different stage of the compilation process. Perhaps, we need to extract it from the source code itself, which we can do since we do know the location of the functions we're analysing. |
The current way we extract function names from arguments in LLVM is rarely successful. This is because the names attached to the LLVM Argument objects are empty, likely removed during the compilation process. This adds an option for looking at debug information to spot the right argument name. Ref: #1175 Signed-off-by: David Korczynski <[email protected]>
* frontend: llvm: catch arg names using debug info The current way we extract function names from arguments in LLVM is rarely successful. This is because the names attached to the LLVM Argument objects are empty, likely removed during the compilation process. This adds an option for looking at debug information to spot the right argument name. Ref: #1175 Signed-off-by: David Korczynski <[email protected]> * nit Signed-off-by: David Korczynski <[email protected]> * output argNames to summary.json Signed-off-by: David Korczynski <[email protected]> --------- Signed-off-by: David Korczynski <[email protected]>
* frontend: llvm: catch arg names using debug info The current way we extract function names from arguments in LLVM is rarely successful. This is because the names attached to the LLVM Argument objects are empty, likely removed during the compilation process. This adds an option for looking at debug information to spot the right argument name. Ref: ossf/fuzz-introspector#1175 Signed-off-by: David Korczynski <[email protected]> * nit Signed-off-by: David Korczynski <[email protected]> * output argNames to summary.json Signed-off-by: David Korczynski <[email protected]> --------- Signed-off-by: David Korczynski <[email protected]>
* frontend: llvm: catch arg names using debug info The current way we extract function names from arguments in LLVM is rarely successful. This is because the names attached to the LLVM Argument objects are empty, likely removed during the compilation process. This adds an option for looking at debug information to spot the right argument name. Ref: ossf/fuzz-introspector#1175 Signed-off-by: David Korczynski <[email protected]> * nit Signed-off-by: David Korczynski <[email protected]> * output argNames to summary.json Signed-off-by: David Korczynski <[email protected]> --------- Signed-off-by: David Korczynski <[email protected]>
We discussed this offline, but it would be very nice to get the function arg names returned in /api/far-reach-but-low-coverage as part of the existing "function-arguments" value.
The text was updated successfully, but these errors were encountered: