libbsd project homepage says it is supported on macOS, but homebrew says it requires linux

[bimimicah]

Description of issue

The libbsd project homepage says it is supported "out of the box" on macOS, but the libbsd homebrew formula says it requires linux. Presumably just removing that line and rebuilding would solve this, if it is truly "out of the box"?

Is this something that can be easily fixed? I don't have access to a mac machine, so I cannot work on this myself.

[Bo98]

It was imported from the linuxbrew-core so is probably simply the case that nobody has requested or needed it yet. This is probably because macOS is a BSD-like OS so its feature set largely already implemented in the OS itself, making libbsd usually unnecessary. Is there a particular feature you're looking for? Would help us understand the use case better.

[Bo98]

I'd be happy to make a PR, removing that requirement line from the formula, but since I can't really test it, that seems a bit dodgy, right?

CI will do a build check + the simple test that you see in the formula itself. It's probably good enough. I'm away for the next week so am unable to much else myself.

[bimimicah]

Interesting given gid_from_group in BSDs is literally just a getgrnam_r + a cache. There shouldn't be any functional difference beyond caching.

I believe that's the whole issue, actually. That for some auth providers (sssd in this case; LDAP/AD/etc.), the cached data is incomplete. The way it was described to me, grp->gr_mem may just be completely empty. Which makes sense if you don't want to copy down the whole LDAP directory to your local computer (or may not even have permission to do so, depending on the logged-in user), I suppose.

EDIT: I misread your message and missed that you were talking about gid_from_group's cache, sorry. If that is the case then we probably can make the change. The rest of this message I'll leave as background info.

[bimimicah]

I will have to ask the commit author to test to know for sure, but I think the PR's change to use getgrouplist() solves that issue, and we may be able to use getgrnam() in this particular case where we only need the grp->gr_gid field

[bimimicah]

I'd be happy to make a PR, removing that requirement line from the formula, but since I can't really test it, that seems a bit dodgy, right?

CI will do a build check + the simple test that you see in the formula itself. It's probably good enough. I'm away for the next week so am unable to much else myself.

A draft PR for CI tests was created here #198648. If that passes all the checks, then I will read all the guidelines and make a proper PR. I hope that is acceptable.

[bimimicah]

I'd be happy to make a PR, removing that requirement line from the formula, but since I can't really test it, that seems a bit dodgy, right?

CI will do a build check + the simple test that you see in the formula itself. It's probably good enough. I'm away for the next week so am unable to much else myself.

I think I have everything in order for the final PR. Please let me know if there is anything else you need from me. Thanks for your help and advice on libbsd alternatives.

[bimimicah]

This was fixed in PR #198648. Thanks for everyone's help.