Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hibernate-core metadata for version 7.0.0 #578

Open
christophstrobl opened this issue Nov 29, 2024 · 5 comments
Open

Add hibernate-core metadata for version 7.0.0 #578

christophstrobl opened this issue Nov 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@christophstrobl
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Hibernate 7.0 already released its Beta2 version. Given the history of the project the new major will likely require a different set of reflection entries.

Describe the solution you'd like
Lift existing tests to new version and provide required metadata.

Describe alternatives you've considered
Hibernate Team provides metadata as part of the lib.

Additional context
none.

@christophstrobl christophstrobl added the enhancement New feature or request label Nov 29, 2024
@vjovanov
Copy link
Member

vjovanov commented Dec 2, 2024

@christophstrobl we are establishing an automatic way of finding these libraries. You can see that in this temporary ticket: #574

@ezzarghili this could be the first candidate to work on as it is needed by the community.

@sdeleuze
Copy link
Collaborator

sdeleuze commented Dec 3, 2024

Would be indeed cool if we could achieve to have a fully automatic agent generated config as of Hibernate 7. And if we can't, we can maybe work with @DSouzaM (contact shared by @vjovanov) to get the agent doing what we need.

@christophstrobl
Copy link
Contributor Author

I agree with @sdeleuze that an automatic way of doing these kind of tasks would be a great thing.
Since tests for hibernate are failing for 7.0 (some deprecated types removed, some types moved to another package, ...), I went ahead and updated tests and metadata (still using old format) based on current preview Beta2 release of hibernate 7.
I'm curious to learn more about the automation and how well it deals with major version upgrades.
In the meantime I'm leaving #579 here (just in case someone else has a need to early test the next major).

@vjovanov
Copy link
Member

@jormundur00 will have a look into making this automatic. @DSouzaM will help him if we need to make modifications to the agent. The documentation on the folowing page should be enough to achieve this: graalvm/native-build-tools#645

@sdeleuze
Copy link
Collaborator

Please ping @christophstrobl and me when you have something we can test (before merging related changes) since we would like to check there is no significant memory consumption regressions and we also want to test those new metadata against our Spring AOT smoke tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants