Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Consider marking Span.constructor protected #142

Open
lcapaldo opened this issue Feb 10, 2020 · 0 comments
Open

Consider marking Span.constructor protected #142

lcapaldo opened this issue Feb 10, 2020 · 0 comments

Comments

@lcapaldo
Copy link

Creating a span via new Span will almost never do what folks intend, especially if they have a non noop tracer. I appreciate that doing this would make the noop tracer implementation for javascript somewhat more complex, but I have seen folks using new Span for "default" parent spans (when using an actual tracer implementation), so it may be worth it to help consumers fall into the "pit of success."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant