You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 23, 2023. It is now read-only.
The current implementation has an interface StartSpanOption where Dave Cheney's article is linked specifying that it is the inspiration for this functionality.
In the article, functional options are presented which are great and are used in many libraries. In functional options we have functions that return the same type, automatically grouping them nicely in documentation, such as for example in the grpc package.
In this library however, they are defined as an interface for no apparent reason. In this case, not only are they harder to implement and provide no real benefit, but also they do not group together in documentation, making doc pages clumsy and hard to follow.
I'd like to suggest to change this.
The text was updated successfully, but these errors were encountered:
The current implementation has an interface
StartSpanOption
where Dave Cheney's article is linked specifying that it is the inspiration for this functionality.In the article, functional options are presented which are great and are used in many libraries. In functional options we have functions that return the same type, automatically grouping them nicely in documentation, such as for example in the grpc package.
In this library however, they are defined as an interface for no apparent reason. In this case, not only are they harder to implement and provide no real benefit, but also they do not group together in documentation, making doc pages clumsy and hard to follow.
I'd like to suggest to change this.
The text was updated successfully, but these errors were encountered: