Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scGPT: use sparse matrix calculations #790

Open
dorien-er opened this issue Apr 19, 2024 · 0 comments
Open

scGPT: use sparse matrix calculations #790

dorien-er opened this issue Apr 19, 2024 · 0 comments

Comments

@dorien-er
Copy link
Contributor

see #754 (comment)

This will expand the sparse matrices into dense matrices again, which unfortunatly will cause out of memory issues. Especially when working at atlas scale.

Looking at the implementations for tokenize_batch https://github.com/bowang-lab/scGPT/blob/706526a76d547de4ed711fa028c99be5bdf6ad8a/scgpt/tokenizer/gene_tokenizer.py#L249

and pad_batch https://github.com/bowang-lab/scGPT/blob/706526a76d547de4ed711fa028c99be5bdf6ad8a/scgpt/tokenizer/gene_tokenizer.py#L312

I feel that an implementation that does not expand the matrices into memory is possible to implement. To be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant