You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there is a code, which is repeated across different components. The examples that I faced are:
Setting up a logger
Subsetting HVG
Extracting a particular layer from AnnData object (e.g. X or specified layer)
Validation of the data in the layer. E.g. check that a matrix contains not-normalized counts
Code copy-pasting is not a good practice. If we decide to change a logging format or a bug is found (see recent PR #385), we must change the code in each component. To prevent this, we should move common code to a separate script or component.
I created such a script in src/ directory in this PR: #385. After merging it, I can move other reused code to this script. Other suggestions about common code location or examples of copy-pasting are welcome :)
The text was updated successfully, but these errors were encountered:
Currently, there is a code, which is repeated across different components. The examples that I faced are:
Code copy-pasting is not a good practice. If we decide to change a logging format or a bug is found (see recent PR #385), we must change the code in each component. To prevent this, we should move common code to a separate script or component.
I created such a script in
src/
directory in this PR: #385. After merging it, I can move other reused code to this script. Other suggestions about common code location or examples of copy-pasting are welcome :)The text was updated successfully, but these errors were encountered: