Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutrition game: small improvements #1098

Open
raphael0202 opened this issue Dec 11, 2024 · 8 comments
Open

Nutrition game: small improvements #1098

raphael0202 opened this issue Dec 11, 2024 · 8 comments

Comments

@raphael0202
Copy link
Contributor

raphael0202 commented Dec 11, 2024

I list here small improvements that can be added to the nutrition game.

Don't display nutrient that are computed and not editable ✅

carbon-footprint-from-known-ingredients, carbon-footprint-from-meat-or-fish (maybe others as well) are computed and should not be displayed in the "Tableau partiellement rempli" mode

Image

Help the user to identify values that changed faster in "Tableau partiellement rempli" mode ✅

We can do this by comparing the predicted nutrition value to the current value for each field. The background color of the text field could be different depending on the comparison:

  • if it's equal, we would have a green background
  • if the current value is null and the predicted value exists, we would have a yellow background
  • if a difference exists, we would have an orange background

Help the user to identify outdated photos faster ✅

Let the user know that the photo he/she is looking at is the selected nutrition photo.

Bug when adding a new nutrient

Image

The nutrient field appears twice, and the name is not the right one.

Don't provide a countries_tags filter when selecting en:world

Otherwise we don't return any prediction (en:world is not added automatically to the countries tags list)

@teolemon
Copy link
Member

Those fields carbon from meat or fish are from 2019 (our first attempt at environmental evaluation) and should be hidden.

@raphael0202
Copy link
Contributor Author

I added two more issues 🙏

@alexfauquette
Copy link
Member

The nutrient field appears twice, and the name is not the right one.

I do not manage to reproduce it. Could you do a screen recording?
O maybe I fixed it in one PR

@raphael0202
Copy link
Contributor Author

I do not manage to reproduce it. Could you do a screen recording?

Capture.video.du.13-12-2024.09.57.55.webm

@alexfauquette
Copy link
Member

Should be fixed now. I'm closing the issue. Feel free to open small ones if you see other paper cuts :)

@github-project-automation github-project-automation bot moved this from To Discuss & Validate to Done in Hunger Games (new) Dec 13, 2024
@raphael0202
Copy link
Contributor Author

raphael0202 commented Dec 13, 2024

Thank you for all the fixes!
The translations are hardcoded for this game, no? The strings don't appear in Crowdin.

A few typos

  • Tableau partielement rempli -> Tableau partielmement rempli
  • afficher le valeurs OFF -> afficher les valeurs OFF

Rotated image issue

And when rotated an image, it was truncated:

Image
Image

Allow to order insights popularity

The /insights endpoint allow to order by popularity, it would be interesting to focus first on most popular products.

@raphael0202 raphael0202 reopened this Dec 13, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Hunger Games (new) Dec 13, 2024
@alexfauquette
Copy link
Member

For the rotated image issue, it's complicated.

The zooming library does not support rotation, and so it's tricky to get the correct scale after a rotation

The translations are hardcoded for this game no?

Yes, once we agree on a "final" version we want to open to the contributors, I will setup the translations

@raphael0202
Copy link
Contributor Author

New feedbacks :)

Invalid field names

when checking the "table with already some data" checkbox", we have some nutrition fields that should not appear:

  • "Energy"
  • "Score nutritionnel - France"

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

3 participants