-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nutrition game: small improvements #1098
Comments
Those fields carbon from meat or fish are from 2019 (our first attempt at environmental evaluation) and should be hidden. |
I added two more issues 🙏 |
I do not manage to reproduce it. Could you do a screen recording? |
Capture.video.du.13-12-2024.09.57.55.webm |
Should be fixed now. I'm closing the issue. Feel free to open small ones if you see other paper cuts :) |
Thank you for all the fixes! A few typos
Rotated image issueAnd when rotated an image, it was truncated: Allow to order insights popularityThe /insights endpoint allow to order by popularity, it would be interesting to focus first on most popular products. |
The zooming library does not support rotation, and so it's tricky to get the correct scale after a rotation
Yes, once we agree on a "final" version we want to open to the contributors, I will setup the translations |
I list here small improvements that can be added to the nutrition game.
Don't display nutrient that are computed and not editable ✅
carbon-footprint-from-known-ingredients
,carbon-footprint-from-meat-or-fish
(maybe others as well) are computed and should not be displayed in the "Tableau partiellement rempli" modeHelp the user to identify values that changed faster in "Tableau partiellement rempli" mode ✅
We can do this by comparing the predicted nutrition value to the current value for each field. The background color of the text field could be different depending on the comparison:
Help the user to identify outdated photos faster ✅
Let the user know that the photo he/she is looking at is the selected nutrition photo.
Bug when adding a new nutrient
The nutrient field appears twice, and the name is not the right one.
Don't provide a
countries_tags
filter when selectingen:world
✅Otherwise we don't return any prediction (
en:world
is not added automatically to the countries tags list)The text was updated successfully, but these errors were encountered: