-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update tool versions #3450
Comments
I would love to add in renovate here and it would be great to use renovate for more than just this too. Given the collector uses it for dependency management, i think we should too. |
I'm all for it, but I'm biased as I'm a maintainer there. 😅 Happy to help out here, even if I had not really much time to help with other topics. |
@secustor if you could help out that would be great :D |
Maybe something to consider in this context would be to sync other reference like the autoinstrumentation versions in |
The situation with versions.txt is a bit more complicated, because that file is a manifest of the defaults used by the operator, and isn't always in sync with the latest instrumentation images. I would like to automate instrumentation library upgrades in the images themselves, and for some of them this is already true, but I'm not fully comfortable doing that without having SDK maintainers as code owners for them. |
If auto merging is not enabled which is the default, you would still have to merge the auto instrumentation PRs manually. |
Consensus from the SIG meeting on 05.12.2024 is that we should do this. |
Describe the issue you're reporting
Our tool versions are pinned in the Makefile, and we don't have any process for updating them. Ideally this should happen the same way as all other dependencies. Same thing goes for the Golang version we use to build our binaries - it's currently pinned to an arbitrary version in the GHA workflow.
My proposal would be to use renovate for this. It's already used elsewhere in otel - notably the collector contrib repo uses it for dependency management, and it is capable of updating versions embedded in arbitrary files.
I successfully achieved this in my fork. With the following configuration:
The text was updated successfully, but these errors were encountered: