Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] review and remove unused exports #5172

Open
pichlermarc opened this issue Nov 18, 2024 · 1 comment
Open

[core] review and remove unused exports #5172

pichlermarc opened this issue Nov 18, 2024 · 1 comment
Labels
feature-request needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation pkg:core target:next-major-release This PR targets the next major release (`next` branch)

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Nov 18, 2024

Description

Important

Do not start working on implementation yet. This work-item still needs to be approved

@opentelemetry/core is a package that holds some shared code that's used across many packages in this repository and the contrib repository. The package currently exports a large public API which we should reduce to improve maintainability.

This issue is considered done if the following steps are completed for each of the current exports in index.ts:

  • if an export is deprecated, remove the export
  • if an export is not used in any other package in this repository or in contrib repository, remove the export
  • if an export is used in exactly one package - move its code to that package (do not export it from the package it was moved to)
  • if an export is only used in tests in this repository, extract it to a new private package @opentelemetry/internal-test-utils
  • if an export is only used in tests in the contrib repository, extract it to the contrib test utils package
  • remove any code that becomes unused through this process

TODO: what to do with things that are better suited to other packages.
TODO: possible way to find the exports

Additional Context

@pichlermarc pichlermarc added feature-request pkg:core needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation target:next-major-release This PR targets the next major release (`next` branch) labels Nov 18, 2024
@SehrishHussain
Copy link

Hi @pichlermarc, is this issue open for contributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation pkg:core target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

No branches or pull requests

2 participants