Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instrumentation): re-export initialize from import-in-the-middle #5123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(instrumentation): re-export initialize from import-in-the-middle #5123

wants to merge 2 commits into from

Conversation

cjpearson
Copy link

Which problem is this PR solving?

This re-exports initialize from import-in-the-middle to support the including or excluding of specific modules.

Fixes #5121

Short description of the changes

Imports and re-exports initialize from import-in-the-middle/hook.mjs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested the following code in an application and confirmed within import-in-the-middle that the provided options are present
import { register } from 'node:module';
register('@opentelemetry/instrumentation/hook.mjs', import.meta.url, { data: { include: [], exclude: [] }})

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjpearson cjpearson requested a review from a team as a code owner November 7, 2024 16:12
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cjpearson / name: Connor Pearson (e1e791a)
  • ✅ login: pichlermarc / name: Marc Pichler (51d2019)

@cjpearson cjpearson force-pushed the feat/initialize-export branch from 16803e7 to e883ea8 Compare November 7, 2024 16:13
trentm
trentm requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for the copyright change.

experimental/packages/opentelemetry-instrumentation/hook.mjs Outdated Show resolved Hide resolved
@trentm
Copy link
Contributor

trentm commented Nov 7, 2024

@cjpearson Oh, also, are you able to sign the CLA (see the earlier comment about that)?

@cjpearson cjpearson force-pushed the feat/initialize-export branch from e883ea8 to e1e791a Compare November 11, 2024 08:54
pichlermarc
pichlermarc approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc requested a review from trentm November 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

@trentm trentm Awaiting requested review from trentm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support include/exclude options from import-in-the-middle
3 participants
@cjpearson @trentm @pichlermarc