-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-trace-base] add debug
-level log with stack trace when modifying neded span
#5113
Labels
good first issue
Good for newcomers
needs:code-contribution
This feature/bug is ready to implement
pkg:sdk-trace-base
type:feature
A feature with no sub-issues to address
Comments
pichlermarc
added
pkg:sdk-trace-base
needs:refinement
This issue needs to be refined/broken apart into sub-issues before implementation
type:feature
A feature with no sub-issues to address
labels
Nov 5, 2024
pichlermarc
changed the title
[sdk-trace-base] add
[sdk-trace-base] add Nov 5, 2024
verbose
-level log with stack trace when verbose
-level log with stack trace when modifying neded span
2 tasks
pichlermarc
changed the title
[sdk-trace-base] add
[sdk-trace-base] add Nov 6, 2024
verbose
-level log with stack trace when modifying neded spandebug
-level log with stack trace when modifying neded span
pichlermarc
added
good first issue
Good for newcomers
up-for-grabs
Good for taking. Extra help will be provided by maintainers
needs:code-contribution
This feature/bug is ready to implement
and removed
needs:refinement
This issue needs to be refined/broken apart into sub-issues before implementation
labels
Nov 6, 2024
@pichlermarc Still up for grabs? Would give it a try |
yep, still up-for-grabs 👍 |
Victorsesan
added a commit
to Victorsesan/opentelemetry-js
that referenced
this issue
Nov 17, 2024
…ded spans, making it easier to trace issues in both Node.js and Browser environments Reviewer: pichlermarc Refs: open-telemetry#5113
👋 @pichlermarc my first shot on this up for review. |
@Victorsesan the commit you linked looks good % the changes to |
Victorsesan
added a commit
to Victorsesan/opentelemetry-js
that referenced
this issue
Nov 20, 2024
…ded spans, making it easier to trace issues in both Node.js and Browser environments Reviewer: pichlermarc Refs: open-telemetry#5113
pichlermarc
removed
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Nov 26, 2024
Victorsesan
added a commit
to Victorsesan/opentelemetry-js
that referenced
this issue
Dec 3, 2024
…ded spans, making it easier to trace issues in both Node.js and Browser environments Reviewer: pichlermarc Refs: open-telemetry#5113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
needs:code-contribution
This feature/bug is ready to implement
pkg:sdk-trace-base
type:feature
A feature with no sub-issues to address
Description
Since the requirement for the OTel API is to not throw when invalid operations are performed, we log a
warning
instead when an operation on an already ended span will have no effect. However, because usually there's no stack trace attached to it, it is difficult to chase down where these invalid operations are happening.The goal of this issue is to add a
debug
-level log right after thewarn
-level log that also provides a stack trace.This issue is considered done when:
debug
-level log has been added that provides a stack tracewarn
-level log message has been amended to mention that changing the level todebug
will provide the stack traceAdditional Requirements
sdk-trace-base
, the chosen approach MUST work for both Node.js and BrowserAdditional Info and Links
opentelemetry-js/packages/opentelemetry-sdk-trace-base/src/Span.ts
Line 367 in eb3ca4f
Span
test file https://github.com/open-telemetry/opentelemetry-js/blob/8900cfdbbab27f464df569a4c8309b96594c276b/packages/opentelemetry-sdk-trace-base/test/common/Span.test.tsThe text was updated successfully, but these errors were encountered: