Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC authenticator for exporter #6952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saxocellphone
Copy link

@saxocellphone saxocellphone commented Dec 13, 2024

Adding missing gRPC authentication features to the experimental Authenticator api. Closes #6953

@saxocellphone saxocellphone requested a review from a team as a code owner December 13, 2024 01:08
Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.06%. Comparing base (e3cfede) to head (8713eed).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...orter/sender/okhttp/internal/OkHttpGrpcSender.java 10.00% 8 Missing and 1 partial ⚠️
...edchannel/internal/UpstreamGrpcSenderProvider.java 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6952      +/-   ##
============================================
- Coverage     90.09%   90.06%   -0.03%     
- Complexity     6601     6603       +2     
============================================
  Files           730      730              
  Lines         19843    19864      +21     
  Branches       1955     1958       +3     
============================================
+ Hits          17877    17890      +13     
- Misses         1371     1379       +8     
  Partials        595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saxocellphone saxocellphone marked this pull request as draft December 13, 2024 01:17
@saxocellphone saxocellphone force-pushed the add_grpc_authentication branch 3 times, most recently from d4606bf to 05f6085 Compare December 13, 2024 20:49
@saxocellphone saxocellphone marked this pull request as ready for review December 13, 2024 21:22
@saxocellphone saxocellphone marked this pull request as draft December 13, 2024 21:53
@saxocellphone
Copy link
Author

saxocellphone commented Dec 13, 2024

I was trying to figure out why the build-graal check is failing. It's complaining about changing a static variable in io.opentelemetry.exporter.internal.auth.Authenticator. Which is WAI. Is the test flaky?

EDIT: fixed by adding the following to resources/META-INF/native-image/io.opentelemetry.opentelemetry-exporter-common/reflect-config.json

  {
    "name":"io.opentelemetry.exporter.internal.auth.Authenticator",
    "queryAllDeclaredMethods":true
  }

@saxocellphone saxocellphone marked this pull request as ready for review December 13, 2024 22:26
@saxocellphone saxocellphone force-pushed the add_grpc_authentication branch from 05f6085 to 8713eed Compare December 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add authentication support for GrpcExporter
1 participant