-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProxyAuthenticator Support for OtlpHttp{Signal}Exporters #6819
Comments
We have an experimental configuration optional called Authenticator modeled after the OkHttp Its a bit hard to use right now.. Something like:
See OkHttpHttpSender for details on how its translated to the Okhttp Is there something specific about proxy authentication that makes our |
@jack-berg The issue is okhttp won't accept |
I see. I think it probably makes sense to add support for setting an Authenticator specifically for use with the proxy. But really we ought to revisit Authenticator, which has been around for a while, yet doesn't feel particularly close to stabilizing, since its not supported in JdkHttpSender, or OkHttpGrpcSender, UpstreamGrpcSender. The concept seems sort of half-baked, and its API and semantics need to be better articulated so it can be supported outside of just OkHttp. |
I realize the Authenticator implementation is still incomplete. In the meantime, would it be acceptable to proceed with adding the Authenticator to ProxyOptions and using it within OkHttpHttpSender? If so, I can contribute and open a PR for review. |
Is your feature request related to a problem? Please describe.
OtlpHttp{Signal}Exporters do support Proxy configuration. Thanks to this issue #6204. However, we don't expose the ProxyAuthenticator that OkHttp requires if want to use an authenticated proxy. See square/okhttp#3607 for more details on why we can't just set the
Proxy-Authorization
header.Describe the solution you'd like
Enhance
ProxyOptions
class to support providingProxyAuthenticator
in addition toProxySelector
.The text was updated successfully, but these errors were encountered: