Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Span#setStatus #6797

Open
jack-berg opened this issue Oct 16, 2024 · 2 comments
Open

Fix Span#setStatus #6797

jack-berg opened this issue Oct 16, 2024 · 2 comments
Assignees
@Victorsesan
Labels
Bug Something isn't working

Comments

@jack-berg
Copy link
Member

As reported by @laurit, Span#setStatus implementation doesn't conform to the spec.

Notably:

  • Status codes form a priority of OK > ERROR > UNSET, where a call to set a lower priority shouldn't be able to override a higher priority status. Currently, its possible for a call with UNSET and override ERROR.
  • Description should be ignored when status is not ERROR, but is not
@jack-berg jack-berg added the Bug Something isn't working label Oct 16, 2024
@Victorsesan
Copy link

@jack-berg Is this still up for grabs? Can you please assign so i can work on it?

Victorsesan added a commit to Victorsesan/opentelemetry-java that referenced this issue Oct 21, 2024
@Victorsesan
setStatus method conforms to the specified behavior regarding status …
7f9ef5f 
…code priorities and description handling

Relate to open-telemetry#6797
@Victorsesan Victorsesan mentioned this issue Oct 21, 2024
Open
@Victorsesan
Copy link

@jkwatson Submitted a PR for review, thanks

Victorsesan added a commit to Victorsesan/opentelemetry-java that referenced this issue Oct 23, 2024
@Victorsesan
fix
ef46f8f 
Relate to open-telemetry#6797
Victorsesan added a commit to Victorsesan/opentelemetry-java that referenced this issue Oct 24, 2024
@Victorsesan
Fixed and adjusted the following.
a9fb915 
*Gradle build in build.gradle.kts had failed during spotless check because the plugin org.graalvm.buildtools.native was not found
-Solution: I have applied a plugin and made it work

*spotlessJavaCheck task failed because certain files did not conform to the formatting rules defined in the Spotless configuration
-Solution: Initiated an auto fix using ./gradlew :sdk:trace:spotlessApply

*Lastly as requested i initiated
./gradlew spotlessApply to ensure a consist code formating and the build was successful with no errors!

Relate to open-telemetry#6797
Victorsesan added a commit to Victorsesan/opentelemetry-java that referenced this issue Nov 3, 2024
@Victorsesan
ensured span's status does not change after it has ended in the nothi…
448ece8 
…ngChangedAfterEnd test

Ref Fix Span#setStatus open-telemetry#6797
Victorsesan added a commit to Victorsesan/opentelemetry-java that referenced this issue Nov 8, 2024
@Victorsesan
Added a new test to help ensure that my setStatus method behaves corr…
8fc9659 
…ectly under the specified conditions, maintaining the integrity of the span's status.

Ref Fix Span#setStatus open-telemetry#6797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Victorsesan Victorsesan

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jack-berg @Victorsesan