Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish otel.spotless-conventions? #4076

Open
trask opened this issue Jan 10, 2022 · 2 comments
Open

Publish otel.spotless-conventions? #4076

trask opened this issue Jan 10, 2022 · 2 comments
Labels
Feature Request Suggest an idea for this project

Comments

@trask
Copy link
Member

trask commented Jan 10, 2022

Pros:

This would enable us to use it across all 4 java repos (core, instrumentation, contrib, docs).

In particular, instrumentation repo has many standalone gradle modules, which currently requires copying spotless configuration across each one (open-telemetry/opentelemetry-java-instrumentation#5058).

Cons:

It's really just for use on OpenTelemetry projects, given that it adds our license header, as opposed to something public for others to use:

/*
 * Copyright The OpenTelemetry Authors
 * SPDX-License-Identifier: Apache-2.0
 */
@jkwatson
Copy link
Contributor

How/where would we do this, do you think?

@anuraaga
Copy link
Contributor

It's always been a goal to publish all the conventions to use among our three repos to reduce code duplication. But keeping the code in sync hasn't been quite annoying enough to prioritize that yet, maybe it's important now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

3 participants