Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate module for JMH benchmarks #3083

Open
piotr-sumo opened this issue Mar 31, 2021 · 1 comment
Open

Create a separate module for JMH benchmarks #3083

piotr-sumo opened this issue Mar 31, 2021 · 1 comment
Labels
Feature Request Suggest an idea for this project help wanted

Comments

@piotr-sumo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are multiple implementations of the SpanProcessor interface. I'd like to compare their performance to pick the one that best fulfils my requirements. Currently, one has to copy benchmarking classes like BatchSpanProcessorBenchmark, BatchSpanProcessorCpuBenchmark etc. Moreover, helper classes like BatchSpanProcessorMetrics also have to be copied. This leads to code duplication. When updating one class, one has to also update its clones.

Describe the solution you'd like
I'd like to have a benchmarking module containing all common code: helper classes and benchmarks.

Describe alternatives you've considered
Alternatively, we could leave code as it is right now.

@harshita19244
Copy link
Contributor

I would like to give this a try, could you assign it to me?

@harshita19244 harshita19244 removed their assignment May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project help wanted
Projects
None yet
Development

No branches or pull requests

3 participants