Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validation methods to public api #2944

Open
jimshowalter opened this issue Feb 26, 2021 · 0 comments
Open

Move validation methods to public api #2944

jimshowalter opened this issue Feb 26, 2021 · 0 comments
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project

Comments

@jimshowalter
Copy link

As discussed in #2935, we need to add our own validation.

In addition, we need to pre-check the values coming in from headers, to avoid trying to call BaggageBuilder.put with a null or empty string.

Currently the code to validate keys and values is in private static methods in ImmutableBuilder, and those in turn call methods that are in io.opentelemetry.api.internal.StringUtils, which is an internal package.

We don't want to just copy this code.

(If it's safe to call code in internal packages, let us know and that part we'll drop from this request.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

2 participants