You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't great for stateful samplers like RateLimitingSampler, which lose their state every update even when no change was supposed to be made. And even if the rate changed without a change in strategy, we would expect the rate to be updated inline without losing other state such as leak level.
The text was updated successfully, but these errors were encountered:
Correction - not only when configuration hasn't changed, stateful samplers in Jaeger implement an Update() function that adapts to changed parameters accordingly while keeping (or adjusting) its internal state, e.g.
Currently jaeger-remote-sampler always reinitializes a sampler when reading configuration
https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java#L93
This isn't great for stateful samplers like RateLimitingSampler, which lose their state every update even when no change was supposed to be made. And even if the rate changed without a change in strategy, we would expect the rate to be updated inline without losing other state such as leak level.
The text was updated successfully, but these errors were encountered: