Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger remote sampler should not reinitialize Sampler when configuration hasn't changed #2465

Open
anuraaga opened this issue Jan 8, 2021 · 1 comment
Labels
Bug Something isn't working

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Jan 8, 2021

Currently jaeger-remote-sampler always reinitializes a sampler when reading configuration

https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java#L93

This isn't great for stateful samplers like RateLimitingSampler, which lose their state every update even when no change was supposed to be made. And even if the rate changed without a change in strategy, we would expect the rate to be updated inline without losing other state such as leak level.

@anuraaga anuraaga added the Bug Something isn't working label Jan 8, 2021
@yurishkuro
Copy link
Member

Correction - not only when configuration hasn't changed, stateful samplers in Jaeger implement an Update() function that adapts to changed parameters accordingly while keeping (or adjusting) its internal state, e.g.

https://github.com/jaegertracing/jaeger-client-go/blob/fe3fa553c313b32f58cc684a59a4d48f03e07df9/sampler.go#L216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants