-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource attributes to Zipkin exporter #1970
Comments
Hmm, this specification seems a bit dubious to me. There can be a lot of resource attributes. Do we really want to duplicate them on each span? |
Do we have any other option? We don't want to loose them completely, do we? |
I never noticed Resource there for some reason - that does seem quite problematic since I think most zipkin deployments will be destroyed if we send all the resource attributes in every span. Considering Zipkin exporter will commonly be used with Zipkin (collector will generally be used with OTLP I guess?), I think we are effectively required to have a configuration knob in the SDK to filter attributes if we do indeed add these. open-telemetry/opentelemetry-specification#823 was pushed to post-GA but it makes me want to remove Resource from the zipkin exporter spec until post-GA too since I think they both need to be considered together. |
Sent open-telemetry/opentelemetry-specification#1185 let's see what people think |
Marking this as blocked by the spec until 1185 is resolved. |
open-telemetry/opentelemetry-specification#1185 has been merged, removing resources from Zipkin for now, so I'm removing the "Bug" label since we are now conformant. The follow-up open-telemetry/opentelemetry-specification#1196 is only "allowed-for-ga", so I think we should not have this issue required-for-ga eiher. |
I wonder if we can just close this and open a new issue if/when 1196 gets resolved in the spec? |
closing due to inactivity, and no support in the specs. |
Specification says:
But
ZipkinSpanExporter
currently translates onlyservice.name
resource attribute and completely ignores all others.The text was updated successfully, but these errors were encountered: