Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency update to go 1.22.7 #5969

Open
codeboten opened this issue Nov 12, 2024 · 9 comments
Open

dependency update to go 1.22.7 #5969

codeboten opened this issue Nov 12, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

Description

Updating the packages to the latest version of the go SDK libraries and saw that the minimum version of go was bumped from 1.22 to 1.22.7 in the dependency change 5e9da3a. Is this intentional? It's causing the collector to need to bump its minimum version as well

Expected behavior

Expected to be able to bump otel-go dependencies without requiring a bump in minimum go version

@codeboten codeboten added the bug Something isn't working label Nov 12, 2024
@pellared
Copy link
Member

pellared commented Nov 12, 2024

I do see requiring to bump a patch version of Go as a bug. We are still supporting the same versions of Go as currently supported by the Go team. I find the changes in https://github.com/grpc/grpc-go/releases/tag/v1.68.0 quite important.

From https://github.com/open-telemetry/opentelemetry-go?tab=readme-ov-file#compatibility:

OpenTelemetry-Go ensures compatibility with the current supported versions of the Go language:

Each major Go release is supported until there are two newer major releases. For example, Go 1.5 was supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8 release.

@codeboten
Copy link
Contributor Author

There was a change to revert that bump grpc/grpc-go@3db86e2

@pellared
Copy link
Member

There was a change to revert that bump grpc/grpc-go@3db86e2

I still do not see requiring to patch Go as a bug. However, if there would be a new go-grpc release that reverts the Go requirements and there will be a considerable pushback to do the same here, then I think we can consider also doing a patch release for OTel Go as well.

@codeboten
Copy link
Contributor Author

@pellared is updating the requirement to 1.22.7 not breaking the requirement to support the two newest versions?

Each major Go release is supported until there are two newer major releases. For example, Go 1.5 was supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8 release.

If that's not the case, then I agree this is not a bug. In the collector we tend to support the lowest patch version of the last 2 go releases

@pellared
Copy link
Member

Yes. That is my interpretation. However, I added this issue as a topic to next SIG meeting agenda as I do (or at least try to) not blindly trust my own judgement.

@pellared
Copy link
Member

Per grpc/grpc-go#7831 we will be able to downgrade back after a new release of grpc-go is published.

@pellared
Copy link
Member

pellared commented Dec 5, 2024

@codeboten, I am not sure if fixing it would be that easy. Our other dependencies (e.g. https://github.com/grpc-ecosystem/grpc-gateway/blob/main/go.mod) did the same thing. Everyone would need to now fix this. I am not sure if it will happen. My guess is that we will have to live with it until we stop supporting 1.22 and start requiring 1.23. Go 1.24 is expected to be released in February 2025. I am leaning towards closing this issue. WDYT?

@codeboten
Copy link
Contributor Author

@pellared it looks like that dep also downgraded back down to 1.22.0, not sure if there's a way to address this or not though. i don't have time to dig down on all the other deps that may have the same issue, but if it's just grpc-gateway, then it should be addressed with their next release

@pellared
Copy link
Member

@codeboten, thanks a lot for the heads up. I can look after January 7. Unassigning myself as maybe someone else would have time to take a look before I am back.

@pellared pellared removed their assignment Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Low priority
Development

No branches or pull requests

2 participants