Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from build-tools to weaver #5668

Open
trisch-me opened this issue Aug 2, 2024 · 7 comments · May be fixed by #5898
Open

Move from build-tools to weaver #5668

trisch-me opened this issue Aug 2, 2024 · 7 comments · May be fixed by #5898

Comments

@trisch-me
Copy link

Hey everyone, semconv is going to deprecate build-tools and actively moving to use weaver. As a part of this effort we are going to update all codegen for different languages including golang.

I will work on updating https://github.com/open-telemetry/opentelemetry-go-build-tools/tree/main/semconvgen and testing it with new weaver docker image.

If you have any questions please let me know

@trisch-me
Copy link
Author

@dmathieu FYI

@dashpole
Copy link
Contributor

We should actually replace semconvgen with weaver.

@jsuereth 's PoC: #5793

Part of open-telemetry/weaver#227

@MrAlias
Copy link
Contributor

MrAlias commented Oct 18, 2024

Looking into how we can preserver our custom capitalizations: open-telemetry/weaver#415

@MrAlias
Copy link
Contributor

MrAlias commented Oct 18, 2024

Comment line wrapping: open-telemetry/weaver#416 open-telemetry/weaver#364

@MrAlias MrAlias linked a pull request Oct 18, 2024 that will close this issue
MrAlias added a commit that referenced this issue Oct 20, 2024
This is the last version of semantic conventions we can generate using
the existing tooling. The next version will require resolution of
#5668.

[Semantic Conventions v1.27.0
Release](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.27.0)

Resolve #5475
@florianl
Copy link

florianl commented Dec 4, 2024

@trisch-me do you happen to have an update on the progress on the work updating https://github.com/open-telemetry/opentelemetry-go-build-tools/tree/main/semconvgen.

Can you share plans or outstanding tasks that would bring this issue forward? Is there a way to help?

@MrAlias or is the plan to dropsemconvgen and migrate the sem conv code generation to weaver?

@trisch-me
Copy link
Author

@florianl I think the best way is to ask @MrAlias about current process as he owns the process now and does migration.

@MrAlias
Copy link
Contributor

MrAlias commented Dec 5, 2024

@florianl please see #5898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants