Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a child span to the grpc e2e test for the server #1442

Open
MrAlias opened this issue Dec 17, 2024 · 0 comments · May be fixed by #1468
Open

Add a child span to the grpc e2e test for the server #1442

MrAlias opened this issue Dec 17, 2024 · 0 comments · May be fixed by #1468

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 17, 2024

To ensure we are correctly tracking the span in the server probe, we should add a child span (i.e. an HTTP or OTel global span), that will be instrumented with the auto project, to ensure that child correctly gets the server span as its parent.

func (s *server) SayHello(ctx context.Context, in *pb.HelloRequest) (*pb.HelloReply, error) {
log.Printf("Received: %v", in.GetName())
if in.GetName() == "unimplemented" {
return nil, status.Error(codes.Unimplemented, "unimplmented")
}
return &pb.HelloReply{Message: "Hello " + in.GetName()}, nil
}

MrAlias added a commit to MrAlias/opentelemetry-go-instrumentation that referenced this issue Dec 18, 2024
Fix open-telemetry#1442

In the gRPC server e2e test create a child span and verify trace info is
correctly passed, and thus verifying our context propagation is correct.
@MrAlias MrAlias linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant