New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused `peer_ptr` in grpc server probe #1432

Open

MrAlias opened this issue Dec 16, 2024 · 0 comments · May be fixed by #1431

Assignees

Milestone

Contributor

MrAlias commented Dec 16, 2024

opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c

Lines 132 to 133 in 9fe05d9

    
           void *peer_ptr = 0; 
        
           bpf_probe_read_user(&peer_ptr, sizeof(peer_ptr), (void *)(http2server + http2server_peer_pos));

This looks like left-over.

MrAlias added this to the v0.20.0-alpha milestone

MrAlias changed the title ~~Remove unused peer_ptr~~ Remove unused peer_ptr in grpc server probe

MrAlias self-assigned this

MrAlias linked a pull request

that will close this issue

Support google.golang.org/grpc v1.69.0 #1431

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment