writeStatus uprobe gets context from argument not struct

[MrAlias]

opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c

Line 199 in 9fe05d9

get_Go_context(ctx, 2, stream_ctx_pos, true, &go_context);

This passes true to get_Go_context as the 4th arg. However, the context is passed as a struct field, not an argument. Meaning this should be false.

I'm not sure how this is currently working. An investigation is needed.

[damemi]

I can take this if you haven't already committed to it @MrAlias

[MrAlias]

FWIW, in my work on #1421 I have changed the value to false and things pass the e2e tests. But I haven't dug into why this is working in the first place and if the test are just false-nagatives.

[MrAlias]

SIG meeting notes: This is likely not getting the correct context, but the writeStatus function is only using this to get a "consistent key". Since Go > 1.17 the consistent key is based on the goroutine ID and not the context. Therefore, this is likely why we have not noticed this: we are not testing with Go <= 1.17.