Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write the flag to enable the autosdk for the otel global #1399

Open
MrAlias opened this issue Dec 10, 2024 · 2 comments · May be fixed by #1405
Open

Write the flag to enable the autosdk for the otel global #1399

MrAlias opened this issue Dec 10, 2024 · 2 comments · May be fixed by #1405
Assignees
@MrAlias

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 10, 2024

Our instrumentation for the OTel global API needs to set this bool when loaded:

https://github.com/open-telemetry/opentelemetry-go/blob/dd83cac3f8f4412bc0c40e739eb33780bd9a3aba/internal/global/trace.go#L152-L159
@MrAlias MrAlias converted this from a draft issue Dec 10, 2024
This was referenced Dec 10, 2024
Draft
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 10, 2024

We will need to work out how to instrument (*tracer).newSpan only for versions > 1.32 of otel.

@MrAlias MrAlias moved this from Todo to In Progress in Go Auto Instrumentation: Beta Dec 10, 2024
@MrAlias MrAlias self-assigned this Dec 10, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 10, 2024

We will need to work out how to instrument (*tracer).newSpan only for versions > 1.32 of otel.

The Optional field should work to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
Go Auto Instrumentation: Beta
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PoC] Enable auto/sdk in otel global MrAlias/opentelemetry-go-instrumentation
1 participant
@MrAlias