Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dockerfile): set USER_GID alongside USER_UID #738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rogercoll
Copy link
Contributor

Fixes #662

@rogercoll rogercoll requested review from a team as code owners November 18, 2024 08:59
@rogercoll rogercoll requested a review from ChrsMark November 18, 2024 08:59
Copy link

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a changelog for this because I'm not sure if this change can cause unexpected issues in some environments.

@rogercoll
Copy link
Contributor Author

I think we should create a changelog for this because I'm not sure if this change can cause unexpected issues in some environments.

Is there any related documentation guidelines? I could not find any changelog file in the repo

@swiatekm
Copy link

I think we use the autogenerated Github release notes in this repo. So no separate changelog necessary.

@mowies
Copy link
Member

mowies commented Nov 18, 2024

would it not be better to add an actual collector changelog entry as a backport in the other repo(s)? This seems important enough to warrant that

@rogercoll
Copy link
Contributor Author

would it not be better to add an actual collector changelog entry as a backport in the other repo(s)? This seems important enough to warrant that

There is a changelog entry in the contrib v0.114.0 release https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.114.0. The core collector does not have a container Dockerfile, maybe we could add a PR with just a changelog entry referencing this PR?

@ChrsMark
Copy link
Member

Could we mention what kind of testing has been performed here? I'm mostly worried about any potential issues this can cause to existing users. I would expect that users using the upstream Helm charts and/or Operator to not be affected. @rogercoll is this verified?

Based on the above ,+1 on surfacing this change as much as possible to the release notes.

@mowies
Copy link
Member

mowies commented Nov 26, 2024

There is a changelog entry in the contrib v0.114.0 release open-telemetry/opentelemetry-collector-contrib@v0.114.0 (release).

perfect

The core collector does not have a container Dockerfile, maybe we could add a PR with just a changelog entry referencing this PR?

the core collector also has one but it's only in the releases repo. In any case, the dockerfile in the contrib repo is only used for testing and not for actual releases. The release dockerfiles are all in the releases repo. So I think it would also be good to have a changelog entry for the core collector just in a standalone PR.

@rogercoll
Copy link
Contributor Author

Could we mention what kind of testing has been performed here? I'm mostly worried about any potential issues this can cause to existing users. I would expect that users using the upstream Helm charts and/or Operator to not be affected. @rogercoll is this verified?

Based on the above ,+1 on surfacing this change as much as possible to the release notes.

I don't think there is any mechanism to test the upstream Helm Charts with an unreleased version of the Collector. But I published an image from this branch and manually tested the OpenTelemetry Demo Chart helm install my-otel-demo open-telemetry/opentelemetry-demo --set opentelemetry-collector.image.repository="rcolles/otelcol-contrib" --set opentelemetry-collector.image.tag="nonrootgroup"

@rogercoll
Copy link
Contributor Author

So I think it would also be good to have a changelog entry for the core collector just in a standalone PR.

Sounds good to me, not sure if these situation has happened before, but here is the changelog PR open-telemetry/opentelemetry-collector#11829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container user 10001 is group root.
6 participants