Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attributes to node and pod entities #36859

Open
jinja2 opened this issue Dec 16, 2024 · 1 comment
Open

add attributes to node and pod entities #36859

jinja2 opened this issue Dec 16, 2024 · 1 comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/k8scluster

Comments

@jinja2
Copy link
Contributor

jinja2 commented Dec 16, 2024

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

Metrics for certain pod/node status fields do not work well for filtering in backends. We'd like to introduce some of this information as metadata on pod and node entities.

Describe the solution you'd like

I'd like to add below additional attributes to the node and pod entity/metadata.

  • k8s.pod.phase - This is similar to the existing metric k8s.pod.phase. The values can be Pending, Running, Succeeded, Failed, Unknown.
  • k8s.pod.status_reason - Similar to k8s.pod.status_reason metric. A brief CamelCase message indicating details about why the pod is in this state. Example values - Evicted, NodeLost, UnexpectedAdmissionError
  • k8s.node.condition_{type} - similar to existing metrics enabled by the config node_conditions_to_report, e.g. k8s.node.condition_ready. Since additional custom node conditions can exist, I think sticking with the k8s native kubelet conditions would be better. Or we can use the node_conditions_to_report config here.

Describe alternatives you've considered

No response

Additional context

No response

@jinja2 jinja2 added enhancement New feature or request needs triage New item requiring triage labels Dec 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jinja2 jinja2 changed the title add attributes to node and pod metadata add attributes to node and pod entities Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/k8scluster
Projects
None yet
Development

No branches or pull requests

1 participant