Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Note names should not exceed windows max file path #222

Open
Nitero opened this issue Dec 1, 2024 · 0 comments
Open

BUG: Note names should not exceed windows max file path #222

Nitero opened this issue Dec 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Nitero
Copy link

Nitero commented Dec 1, 2024

Version:

  • OS: Windows
  • Browser: Firefox
  • Web Clipper version: 0.10.0
  • Obsidian version: 1.7.7

Describe the bug

Notes with a name that exceed the windows character limit (247?) seem to work fine at first glance but pose issues for git and potentially other things. For example when I tried renaming a clipped file with a long name I suddenly had two versions in my vault and renaming it in the windows explorer does not work until you decrease the length.

Expected behavior

I would expect the note name to be cut to fit the OS max path settings. Maybe this could be a toggle in the settings, since it's not always an issue? I was also kind of expecting the safe_name filter to solve this, but looks like it only sanatizes symbols and not length?

URLs where the bug occurs

https://lemmy.world/post/18392286

To reproduce

  1. Make a template with this as the note name: {{title|trim|safe_name}} ({{domain}})
  2. Clip this page to obsidian
  3. Go to the created file in the windows explorer and try renaming it, which will be impossible without trimming it first
  4. Optionally try to commit the file to a git repository and get the error "fatal: Unable to process path"
@Nitero Nitero added the bug Something isn't working label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant