Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor examples #37

Open
Sytten opened this issue Jun 21, 2022 · 8 comments
Open

Refactor examples #37

Sytten opened this issue Jun 21, 2022 · 8 comments

Comments

@Sytten
Copy link
Collaborator

Sytten commented Jun 21, 2022

I think we should refactor examples to accommodate for WASM and graphql-client.
Probably using different packages.
What do you think?

@obmarg
Copy link
Owner

obmarg commented Jun 28, 2022

Yeah, not against refactoring the examples now there's support for just cynic. What did you have in mind re: different packages?

@Sytten
Copy link
Collaborator Author

Sytten commented Jun 28, 2022

At least one package for cynic, graphql-client and later wasm. That would be good enough for now.

@obmarg
Copy link
Owner

obmarg commented Jun 29, 2022

If you just mean separate packages for cynic examples, graphql-client examples etc. then yeah - sounds good to me

@HuakunShen
Copy link

HuakunShen commented May 6, 2023

Is there examples for graphql-client? That would be very helpful.

I cannot find an example online.

@obmarg
Copy link
Owner

obmarg commented May 6, 2023

@HuakunShen - I'm afraid I've never used this library with graphql-client.

@Sytten - don't suppose you've got any example code you can share?

@obmarg
Copy link
Owner

obmarg commented May 6, 2023

@HuakunShen you could probably borrow some code from the railway CLI where they're using this library with graphql_client

@HuakunShen
Copy link

@obmarg Thank you!

In the README, it says there is integration with graphql-client: features = ["client-graphql-client"]

What does this mean? I thought graphql-client is supported.

I will take a look at railway first.

@obmarg
Copy link
Owner

obmarg commented May 6, 2023

@obmarg Thank you!

In the README, it says there is integration with graphql-client: features = ["client-graphql-client"]

What does this mean? I thought graphql-client is supported.

It means that you need to enable the client-graphql-client feature flag to get graphql-client support like the railway people have done here. We have support for multiple graphql clients, and control which are enabled via feature flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants