Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription Support #148

Closed
8 of 10 tasks
obmarg opened this issue Dec 12, 2020 · 2 comments
Closed
8 of 10 tasks

Subscription Support #148

obmarg opened this issue Dec 12, 2020 · 2 comments
Assignees
@obmarg
Labels
✨ enhancement New feature or request
Milestone
v0.13.0

Comments

@obmarg
Copy link
Owner

obmarg commented Dec 12, 2020 •
edited
Loading

Cynic doesn't currently support subscriptions.

This issue is to track adding support for them.

There's quite a few moving parts to this, but it's mostly extending what's already there. Happy to help guide any newcomers through the implementation if they want to take this.
@obmarg obmarg added the ✨ enhancement New feature or request label Dec 12, 2020
@obmarg obmarg added this to the v0.12.0 milestone Dec 14, 2020
@obmarg obmarg added good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 31, 2020
@obmarg obmarg self-assigned this Jan 2, 2021
@obmarg obmarg mentioned this issue Jan 2, 2021
Merged
obmarg added a commit that referenced this issue Jan 2, 2021
@obmarg
Support subscription operations (#177)
6902f17 
#### Why are we making this change?

I want to add support for subscriptions to cynic.

#### What effects does this change have?

Adds support for building subscription operations to cynic:

- Added a new SubscriptionRoot marker trait, equivalent to the existing
  QueryRoot & MutationRoot.
- Added a SubscriptionBuilder, equivalent to QueryBuilder & MutationBuilder.
- Added a new StreamingOperation, similar to Operation but for operations that
  stream responses (i.e. subscriptions)

This is mostly untested currently as I haven't yet added support for any 
streaming transports.  That will be coming soon.

Part of #148
@obmarg
Copy link
Owner Author

obmarg commented Feb 14, 2021

Have ended up putting put most of the graphql-ws code into a separate crate so it can be used with other graphql libraries, and be updated independantly from cynic: https://github.com/obmarg/graphql-ws-client

@obmarg obmarg mentioned this issue Feb 22, 2021
Closed
@obmarg
Copy link
Owner Author

obmarg commented Feb 22, 2021

Tracking other websocket libs here: obmarg/graphql-ws-client#11

@obmarg obmarg closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obmarg obmarg

Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
1 participant
@obmarg