Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: The popup was closed (Sporadic) #94

Open
dcrockwell opened this issue Jan 8, 2017 · 5 comments
Open

Error: The popup was closed (Sporadic) #94

dcrockwell opened this issue Jan 8, 2017 · 5 comments

Comments

@dcrockwell
Copy link

dcrockwell commented Jan 8, 2017

Hello, I saw two other reports of this problem, but neither other report seemed to address the popup working 9/10 times, and failing 1/10 times with "Error: The popup was closed".

When a failure occurs, I can trigger a new .popup("facebook") with no problems directly afterwards (again, with a 1/10 chance that it will fail a second time).

  • Whitelist is setup correctly (as evident that the popup works 9/10 times).
  • Always triggered by a user initiated click.

Will attempt to use the raw FB javascript SDK login method to see if it's an issue with Facebook or OAuth.io

@dcrockwell
Copy link
Author

The raw Facebook Javascript SDK's .login method works 100% of the time, so it seems to be an issue isolated to oauth-js.

For now, our solution is to revert back to using the Facebook SDK to call .login directly. Haven't tested with other services like Twitter, etc.

@dcrockwell
Copy link
Author

I don't know what changed, but now the error is happening 9/10 times or more.

The problem doesn't seem to affect OAuth for phonegap, or the Facebook SDK itself which authenticates 100% of the time.

@dcrockwell
Copy link
Author

The change that seems to have caused it to fail far more often is to use .login on MacOS while the browser is in fullscreen mode.

Something about it opening the login window in a tab causes it to fail over and over.

@dcrockwell
Copy link
Author

This problem seems strongly related to a fullscreened chrome in macOS

  • Firefox does not have failures when fullscreened.
  • Safari does not have failures when fullscreened.
  • Chrome does often.

@dcrockwell
Copy link
Author

Exact same problem happens on Chrome on Android: "Error: The popup was closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant