Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Functions mapped should respect user mappings #153

Open
kdheepak opened this issue Jul 22, 2020 · 5 comments · May be fixed by #154
Open

Functions mapped should respect user mappings #153

kdheepak opened this issue Jul 22, 2020 · 5 comments · May be fixed by #154

Comments

@kdheepak
Copy link
Contributor

kdheepak commented Jul 22, 2020 •
edited
Loading

This function overrides a user mapping if it exists:

completion-nvim/lua/completion.lua

Line 128 in 8aecb23

function M.on_InsertEnter()

We discovered this issue 3 hours into @tjdevries stream on Tuesday, July 21st, 2020.
@kdheepak kdheepak changed the title Functions should respect user mappings Functions mapped should respect user mappings Jul 22, 2020
@haorenW1025
Copy link
Collaborator

Hmm I don't quite understand what you mean...can you give me more information? Or like an example?

@kdheepak
Copy link
Contributor Author

I was going to clip it from the stream but the moment passed. I'll track down the exact point in the vod and paste the link here.

@kdheepak
Copy link
Contributor Author

https://www.twitch.tv/videos/686790147?t=02h58m27s

@haorenW1025
Copy link
Collaborator

Ahh got it. I guess the problem is not in that function though. I'll fix that. Thanks for reporting:)

@tjdevries
Copy link
Member

The real issue is that you weren't there to watch the stream... 😆

@haorenW1025 haorenW1025 linked a pull request Jul 23, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid overwrting user defined mapping nvim-lua/completion-nvim
3 participants
@kdheepak @tjdevries @haorenW1025