Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous comment when verifySubmitterjob fails #3808

Open
nvdaes opened this issue Jun 16, 2024 · 0 comments
Open

Superfluous comment when verifySubmitterjob fails #3808

nvdaes opened this issue Jun 16, 2024 · 0 comments

Comments

@nvdaes
Copy link
Contributor

nvdaes commented Jun 16, 2024

Summary

The createManualApproval job is triggered when verifySubmitter job fails, and this maybe hard to avoid.
This is harmless and doesn'thave negative effects, since the pull request to approve add-ons won't be created, because the reviewedAddons.json file is not modified by previous jobs. However, the superfluous comment may be confusing.
See

#3086, specifically:

#3806 (comment)

Proposal

Create a PR in nvaccess/addon-datastore-staging, trying to post the comment just if the cpr step has a number corresponding to a created pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant