Reviews for Gestor de Pomodoros (gestorDePomodoros)

[github-actions[bot]]

Locked - see duplicate discussion: #3190

Community add-on reviews for Gestor de Pomodoros.
Please use threaded replies and avoid email responses.
You can specify the add-on version and other info that you consider relevant in your comment.
Reviews should abide by the NVDA code of conduct.

[nvdaes]

Thanks for your work, @jpavonabian
This review applies to version 1.3 of the add-on, tested with NVDA 2024.1rc1 on Windows 11.
I've looked at the source code and documentation, in addition to testing the add-on.
control+shift+NVDA+p gesture doesn't work, and it doesn't appear in the input gestures dialog of NVDA.
When pressing NVDA+shift+p just once, Pomodoro maybe restarted, or the remaining time is reported. Pressing it twice, Pomodoro is paused. I think that it would be more intuitive if a different keystroke was used to report the remaining time, since someone may want to report it without remembering that Pomodoro is currently paused, but pressing NVDA+shift+p, Pomodoro would be restarted.
In short, imo, this version is not ready for production, but it's a promising and interesting add-on.
As a complementary note, The code is not easy to review since it contains comments and names mixing English and Spanish.

[jpavonabian]

Thank you for the review. There were certainly inconsistencies in the documentation. I have made changes and upgraded to the next version, there is now a separate keyboard shortcut for each action and they appear correctly in the input gestures. El dom, 7 abr 2024 a las 7:21, Noelia Ruiz Martínez (< ***@***.***>) escribió:

…

Thanks for your work, @jpavonabian <https://github.com/jpavonabian> This review applies to version 1.3 of the add-on, tested with NVDA 2024.1rc1 on Windows 11. I've looked at the source code and documentation, in addition to testing the add-on. control+shift+NVDA+p gesture doesn't work, and it doesn't appear in the input gestures dialog of NVDA. When pressing NVDA+shift+p just once, Pomodoro maybe restarted, or the remaining time is reported. Pressing it twice, Pomodoro is paused. I think that it would be more intuitive if a different keystroke was used to report the remaining time, since someone may want to report it without remembering that Pomodoro is currently paused, but pressing NVDA+shift+p, Pomodoro would be restarted. In short, imo, this version is not ready for production, but it's a promising and interesting add-on. As a complementary note, The code is not easy to review since it contains comments and names mixing English and Spanish. — Reply to this email directly, view it on GitHub <#3135 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADDAHDXY6HTIE3UNMHCKNHDY4DJV5AVCNFSM6AAAAABF27MLGCVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TAMZTG42TA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[nvdaes]

This review applies to version 1.4.
Once more, seems that this add-on is not ready for production, and at least it should have been released under the beta channel, not stable.

• NVDA+shift+o is used by NVDA for reporting objects with laptop keyboard layout, and this add-on is covering this gesture. Though this can be changed, I think that NVDA core gestures shouldn't be made unusable by add-ons, unless it is intentional for any reason.
• • NVDA+shift+r is also used in Word and Excel.

I won't make more reviews for this add-on if a beta version is not provided.
Thanks