Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upgrade): add --dedupe as option #573

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(upgrade): add --dedupe as option #573

wants to merge 5 commits into from
+45 −12

Conversation

OrbisK
Copy link
Contributor

@OrbisK OrbisK commented Nov 20, 2024 •
edited by danielroe
Loading

🔗 Linked issue

resolves #554

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

nuxi upgrade was not able to dedupe lockfile. I've added dedupe command for all supprted package managers (npm, pnpm, yarn)

pnpm nuxi upgrade --dedupe

or via pnpm nuxi upgrade prompt

ℹ Package manager: pnpm 9.13.2                                                                                                                                                                                           13:32:01
ℹ Current Nuxt version: 3.14.1592                                                                                                                                                                                        13:32:01

❯ Would you like to dedupe your lockfile (recommended) or force recreate node_modules and pnpm-lock.yaml to fix problems with hoisted dependency versions and ensure you have the most up-to-date dependencies?
● dedupe (Recommended)
○ force
○ skip

@OrbisK OrbisK requested a review from danielroe as a code owner November 20, 2024 12:32
@OrbisK
Copy link
Contributor Author

OrbisK commented Nov 20, 2024

this type error is from consola and is already fixed, but not released yet: unjs/consola@3bd4ae6

danielroe
danielroe reviewed Nov 28, 2024
View reviewed changes
src/commands/upgrade.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9380964). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/upgrade.ts 0.00% 38 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             main    #573   +/-   ##
======================================
  Coverage        ?   1.30%           
======================================
  Files           ?      44           
  Lines           ?    2837           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2758           
  Partials        ?      42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe requested a review from pi0 November 28, 2024 11:54
@danielroe
Copy link
Member

I think this is great - would you be able to raise dedupe functionality as a PR to https://github.com/unjs/nypm ? 🙏

@OrbisK
Copy link
Contributor Author

OrbisK commented Nov 28, 2024

I think this is great - would you be able to raise dedupe functionality as a PR to https://github.com/unjs/nypm ? 🙏

sure 👍🏽

@OrbisK OrbisK mentioned this pull request Nov 28, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(upgrade): allow dedupe instead of deleting lockfile
3 participants
@OrbisK @codecov-commenter @danielroe