Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deprecate imports option. #25

Open
dvlden opened this issue Nov 21, 2020 · 1 comment
Open

Don't deprecate imports option. #25

dvlden opened this issue Nov 21, 2020 · 1 comment

Comments

@dvlden
Copy link

dvlden commented Nov 21, 2020

My suggestion is to not deprecate this option, but tweak it for a slightly different use.

For those that aren't aware all those that had the license for Font Awesome 5, can no longer install Font Awesome from their official npm repository. The license is not longer valid, but there's also a guide in the official docs where it is shown that you can download the .tar and host it somewhere privately for your personal use.

Since this breaks one of my projects and I do not wish to pay $100/y for Font Awesome v6, my only option is to follow that guide.

Hosting Font Awesome myself under my private Git repository of a project, under different scope. So without this imports option, I wouldn't be able to provide a set of the pro icons (v5) that are still valid.

I hope I was able to provide valuable information here. Please keep this option for such purposes.

For example, this is the config that I'm currently using:

fontawesome: {
    component: 'Fa',
    suffix: false,
    useLayers: false,
    useLayersText: false,
    icons: {
      brands: [
        'faCcVisa',
        'faCcMastercard',
        'faCcDiscover',
        'faCcAmex',
        'faCcPaypal',
        'faLinkedinIn',
        'faInstagram',
        'faTwitter'
      ]
    },
    imports: [
      {
        set: '@xxx/xxx-xxx-xxx',
        icons: [
          'faUsersCrown',
          // ...
        ]
      }
    ]
}
@pimlie
Copy link
Member

pimlie commented Nov 28, 2020

What about using an webpack alias for fontawesome instead? If the only thing you need is to be able to use a local/custom import name then you could use that.

Maybe we can provide a simple/shortcut config option for that? This should work as import aliases would only ever be needed for pro icon sets (maybe the config key should indicate this):

fontawesome: {
  importAliases: {
    solid: '@xx/xxx-xx-xx'
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants