Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_notebooks should be able to take a glob #39

Open
rgbkrk opened this issue Sep 27, 2017 · 3 comments
Open

read_notebooks should be able to take a glob #39

rgbkrk opened this issue Sep 27, 2017 · 3 comments
Labels
idea An idea which is open to discussion rather than a particular issue or bug

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Sep 27, 2017

Instead of having to have a special directory to read from, I'd like to be able to read in a collection of notebooks like this:

pm.read_notebooks('out-*.ipynb')

I'm assuming this could probably be done with the glob module.

@mpacer
Copy link
Member

mpacer commented Oct 25, 2017

Would it create a list of notebook node objects obeying my the order spat out by the glob?

@mpacer
Copy link
Member

mpacer commented Oct 25, 2017

If this were python 3 only, I'd say it should accept any iterable that can return filepath objects or strings that map onto filepaths (which I believe is what glob natively returns).

@rgbkrk
Copy link
Member Author

rgbkrk commented Oct 25, 2017

Would it create a list of notebook node objects obeying my the order spat out by the glob?

Yeah I think so.

If this were python 3 only, I'd say it should accept any iterable that can return filepath objects or strings that map onto filepaths (which I believe is what glob natively returns).

We're Python 2.7 + Python 3. I think we could let the argument be a string or a non-string iterable, handling both the glob and directory version, while also letting it take an iterable.

@MSeal MSeal added the idea An idea which is open to discussion rather than a particular issue or bug label Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea An idea which is open to discussion rather than a particular issue or bug
Projects
None yet
Development

No branches or pull requests

3 participants