Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Readme declares incorrect node support matrix #7984

Open
2 tasks done
nbbeeken opened this issue Dec 16, 2024 · 2 comments · May be fixed by #7985
Open
2 tasks done

[DOCS] Readme declares incorrect node support matrix #7984

nbbeeken opened this issue Dec 16, 2024 · 2 comments · May be fixed by #7985
Labels
Documentation documentation related issue Needs Triage needs review for next steps

Comments

@nbbeeken
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

This is a CLI Docs Problem, not another kind of Docs Problem.

  • This is a CLI Docs Problem.

Description of Problem

The readme says:

18.x.x >= 18.17.0
20.5.0 or higher

The package.json engine field says:

  "engines": {
    "node": "^20.17.0 || >=22.9.0"
  }

Potential Solution

I assume the latter is the truth, would someone be able to confirm? Readme update should be trivial. Unfortunately, npm won't show the correct matrix until the next release.

Affected URL

https://www.npmjs.com/package/npm
@nbbeeken nbbeeken added Documentation documentation related issue Needs Triage needs review for next steps labels Dec 16, 2024
@nbbeeken nbbeeken linked a pull request Dec 16, 2024 that will close this issue
Open
@milaninfy milaninfy mentioned this issue Dec 17, 2024
Closed
2 tasks
@nbbeeken
Copy link
Author

Should this be mentioned in the release as well: https://github.com/npm/cli/releases/tag/v11.0.0? There is a conspicuous lack of "breaking changes" as there was in v10: https://github.com/npm/cli/releases/tag/v10.0.0 🤔 something amiss with the release generate tooling?

@si458
Copy link

si458 commented Dec 18, 2024

this bug just completely broke our docker build for our community application
https://github.com/Ylianst/MeshCentral/actions/runs/12399121550/job/34613368323
docs indeed state 20.5.x but the package.json states 20.17.x,
but whats more annoying is alpine package repo only have 20.15.x installed
so we have to move to alpine 3.21 to install node 22 instead which we didnt want to do yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation documentation related issue Needs Triage needs review for next steps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update npm node versions in readme.md nbbeeken/cli
2 participants
@si458 @nbbeeken